Skip to content

Viewer E2E script fails unless the .nvmrc Node version is installed under nvm #115

Open

Description

@fjlopez

What is wrong

scripts/e2e-viewer.mjs reads the viewer .nvmrc and requires that Node version to exist under nvm. It does not accept node from PATH. An fnm, Volta, asdf, mise, or system install of the same version still fails the script.

Where

scripts/e2e-viewer.mjs lines 24-36. When front/viewer/sitmun-viewer-app/.nvmrc exists, the script joins NVM_DIR (or ~/.nvm) with versions/node/v<version>/bin and exits if node is missing there. The viewer .nvmrc exists and contains 24.22.0.

The script was not executed.

Why it matters

npm run e2e:viewer cannot start the viewer on a machine that already has the required Node version outside nvm.

Smallest fix

If that nvm directory is missing, keep the current PATH when node is executable. Prepend the nvm bin directory when that install exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingconfirmedReproduced / accepted defect; exempt from stale bot

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions