Skip to content

Add required security variables at .env templates #134

Closed

Description

@RT-DIBA

Is your feature request related to a problem? Please describe.
The changes applied at cc5934b commit stablish that some security variables are defined as “required”. More specifically: SITMUN_USER_SECRET, MIDDLEWARE_SECRET, SITMUN_MBTILES_JOB_HANDLE_SECRET
These changes require that these three variables are enabled and with data at .env file. If don’t, docker compose can not works and produced the errors showed at the screenshot:

Image

The .env file is created from .env files templates as oracle.env or postgre.env. the .env templates doesn’t contain the definition of SITMUN_USER_SECRET and SITMUN_MBTILES_JOB_HANDLE_SECRET, only contains the MIDDLEWARE_SECRET variable that is commented.
The fact that these variables do not appear in the .env file templates can cause confusion for the user when creating these variables.

Describe the solution you'd like
The .env file templates could contain the definition of the required variables. The documentation could include the need to create the values for these variables using

Additional context
1.2.9 (dev branch)

Activity

  1. added
    enhancementNew feature or request
    confirmedReproduced / accepted defect; exempt from stale bot
    on Oct 30, 2026
  2. fjlopez commented on Oct 30, 2026

    @fjlopez
    Contributor

    Validation: PARTIAL (evidence:confirmed).

    On dev (8b1a6183), root docker-compose.yml refuses to start unless SITMUN_USER_SECRET, MIDDLEWARE_SECRET, and SITMUN_MBTILES_JOB_HANDLE_SECRET are set (:?, cc5934b, #129). README.md already documents openssl rand -hex 32 for all three. setup.sh and setup.ps1 append them only when they create a missing .env from profiles/development-postgres.env.

    Gap: every file under profiles/*.env (postgres.env, oracle.env, development.env, development-postgres.env, development-oracle.env, development-lvh.env) still has only a commented # MIDDLEWARE_SECRET=your-secure-secret-here. SITMUN_USER_SECRET and SITMUN_MBTILES_JOB_HANDLE_SECRET are not named. cp profiles/postgres.env .env or cp profiles/oracle.env .env, then docker compose up, fails with variable is required, as reported. setup.sh does not fill secrets into an .env that already exists.

    Templates should name the three keys and point at the existing generate step. They should not store secret values.

  3. added theissue type on Oct 30, 2026
  4. fjlopez commented on Oct 30, 2026

    @fjlopez
    Contributor

    Validation: DONE (evidence:confirmed). Evidence: #136 merged to dev as 827fc3cf. Each profiles/*.env names SITMUN_USER_SECRET, MIDDLEWARE_SECRET, and SITMUN_MBTILES_JOB_HANDLE_SECRET and leaves them unset. tools/scripts/check-compose-secrets.sh passed on that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmedReproduced / accepted defect; exempt from stale botenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions