Skip to content

Exclude node_modules from root Docker build context #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jay23606 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exclude node_modules from root Docker build context #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@ __pycache__/
# src/ (source code)
# *.ts, *.js, *.java (source files)
# docker-compose.yml, Dockerfile, .dockerignore
# Dependencies (exclude installed, but KEEP package.json and package-lock.json)
node_modules/
**/node_modules/
11 changes: 11 additions & 0 deletions tests/dockerignore.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import assert from 'node:assert/strict';
import { readFile } from 'node:fs/promises';
import test from 'node:test';

test('root Docker build context excludes installed Node dependencies', async () => {
const dockerignore = await readFile(new URL('../.dockerignore', import.meta.url), 'utf8');
const patterns = new Set(dockerignore.split(/\r?\n/));

assert.ok(patterns.has('node_modules/'), 'missing node_modules/ exclusion');
assert.ok(patterns.has('**/node_modules/'), 'missing **/node_modules/ exclusion');
});