Repository navigation
fix(liquibase): keep populated Oracle observed instants on upgrade - #137
Merged
Merged
Conversation
Copy stored UTC values before the empty-column ALTER. A Europe/Madrid session would otherwise shift every existing service check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEC_OBSERVEDandSCS_OBSERVEDvalues are copied as UTC before the empty-columnALTER. TheALTERchangesets are unchanged.bdd95385on sitmun-backend-core#355. That pull request does not close this issue.Fixes #135
CI
oracle-fromanddev-oracle-fromrun the new changesets on empty tables.test-oracleruns the populated case,ServiceCheckOracleObservedRebuildIT.prepare-extracted-unitrunstools/tests/test_service_check_observed_rebuild_order.py.Test plan
oracle-fromanddev-oracle-frompassprepare-extracted-unitpassestest-oracleon pull request 355 passesServiceCheckOracleObservedRebuildIT