Repository navigation
fix(setup): append compose secrets when .env already exists - #139
Merged
Merged
Conversation
Windows PowerShell has no openssl, and the install docs told operators to append the three secrets with bash openssl after copying a profile. setup.sh and setup.ps1 now fill any missing key on an existing .env. Fixes #138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.shandsetup.ps1appendSITMUN_USER_SECRET,MIDDLEWARE_SECRET, andSITMUN_MBTILES_JOB_HANDLE_SECRETwhen.envalready exists and a key is absent. An existing value is kept.openssl. Copy the profile, then run./setup.ps1(or./setup.shon Unix).Fixes #138
Test plan
bash tools/tests/test_setup_compose_secrets.sh(copied profile gets three 64-hex secrets, an existing value is kept, a missing.envis still created from the development PostgreSQL profile, README and profile templates no longer mentionopenssl rand)setup.ps1was not executed in this environment (no PowerShell). The script change matches the shell path: the threeAdd-ComposeSecretIfMissingcalls run after the missing-file copy.