Repository navigation
refactor(e2e): delete helpers with no caller - #83
Merged
Merged
Conversation
expandNode, insertVisualSiblingParagraph, putPlantillaParameter, and _yaml_escape each appeared only at their definition. Call sites already use expandNodeByTitle, insertVisualSiblingAfter, and addMiaParameter.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A search under
e2e/andtools/findsexpandNode,insertVisualSiblingParagraph,putPlantillaParameter, and_yaml_escapeonly at their definitions. Keeping them invites a later edit that nothing calls.What changed
expandNodefrom the layer catalog spec. Call sites useexpandNodeByTitle.insertVisualSiblingParagraph. Call sites useinsertVisualSiblingAfter.putPlantillaParameter. Call sites useaddMiaParameter._yaml_escape.Scope
This covers those four functions. It leaves
switchTemplateEditorToVisual,expandNodeByTitle, and every other helper that still has a caller.Blast Radius
Nothing in
e2e/ortools/calls the deleted functions, so the specs and the schema-drift report keep the same behavior.Verification
python3 -m unittest tools.tests.test_report_schema_drift -vfinished OK, 12 tests.npx playwright test --listlisted 61 tests in 23 files. Playwright was listed, not executed.