Repository navigation
docs(e2e): move the capas gfi comment - #84
Merged
Merged
Conversation
The Capas GFI note sat on identifyAtMapCenter, which already documents the map-center callback. The toggle it describes is enableCapasGfi. The save_baseline comment described a format branch the loop does not take.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Capas GFI note sat on
identifyAtMapCenter, which already documents the map-center callback. The toggle it describes isenableCapasGfi. Thesave_baselinecomment described a format check the loop does not make. The loop always writesidandbaseline_code.What changed
enableCapasGfi.save_baseline. The docstring still names both accepted shapes.Scope
Comment placement only. This leaves function bodies, the
is_ancestorhandler, and the narrating-comment sweep for the next change.Blast Radius
Readers of the viewer helper and the baseline writer. Runtime behavior is unchanged.
Verification
python3 -m unittest discover -s tools/tests -p 'test_*.py'finished OK, 46 tests, one skip (filesystem is case-insensitive). None of those tests asked for a database.npx playwright test --listlisted 61 tests in 23 files. Playwright was listed, not executed.