Repository navigation
docs(tools): delete narrating comments - #85
Merged
Merged
Conversation
The comments restated the next statement. The notes that name git-log order, the no-next-changelog rule, and the language-id selector stay. The is_ancestor exception handler is unchanged.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slice 20 lists comments under
tools/binthat restate the next statement. A reader can see the statement. The notes that name a real rule stay.What changed
is_ancestorexception handler.Scope
Comment text under
tools/binonly. This leavestools/i18n-utils/sort_and_complete_translations.py, because that file is outsidetools/bin. It also leaves theis_ancestorexception handler.Blast Radius
Readers of those scripts. The scripts do the same work.
Verification
python3 -m unittest discover -s tools/tests -p 'test_*.py'finished OK, 46 tests, one skip (filesystem is case-insensitive). None of those tests asked for a database. Playwright was listed on the earlier commits in this stack, and was not executed. This commit does not change a spec.