Repository navigation
Five Data REST tests boot an embedded server the MockMvc suites already cover #316
Description
What is wrong
Five tests use @SpringBootTest(webEnvironment = RANDOM_PORT) and RestTemplate against http://localhost:{port}.
DatabaseConnectionRepositoryIntegrationTest pays the port bind (4.40s gap on the 2026-10-21 H2 run). These four then reuse that context at a 0s gap:
RoleRepositoryIntegrationTestTerritoryRepositoryIntegrationTestTerritoryGroupTypeRepositoryIntegrationTest(@Deprecated)UserResourceIntegrationTest
They assert HAL status and JSON. Sibling *DataRestTest classes already observe that contract with MockMvc on the shared MOCK context. Login goes through TestUtils.adminAuthHeaders (admin_access_token and X-SITMUN-Client).
Why this is not a test-only edit
Replacing RestTemplate with MockMvc is a route decision. The cookie login may not be what the MockMvc Data REST tests send. UserResourceIntegrationTest create-and-delete also overlaps UserResourceTest. Keep the 404-after-delete check on one surface. That overlap is #313.
Done when
One HTTP entry point covers each of these contracts, and the embedded server is gone unless a test needs a real port.
Activity
fjlopez commentedon Oct 21, 2026
A later H2 run the same day, 08:04:19Z to 08:06:49Z, measured a 1.53s gap before
DatabaseConnectionRepositoryIntegrationTestand 1.289s of method time for its three tests. The issue's 4.40s gap is from the earlier run. The fiveRANDOM_PORTclasses are unchanged.The working tree deletes
@DisabledputCanUpdateCartographySpatialSelectionConnection. That method did not run, so removing it does not remove the port.TestUtils.adminAuthHeadersand the sibling MockMvc overlap, including #313, still stand.fjlopez commentedon Oct 21, 2026
Fixed on dev by #349.