Repository navigation
Liquibase JPA slices each load a private configuration #317
Description
What is wrong
These @DataJpaTest slices @ImportAutoConfiguration(LiquibaseAutoConfiguration.class) and keep the extra beans in a private nested @TestConfiguration. The nested class is part of the context key, so each slice runs the changelog on its own context. Gaps before the suite on the 2026-10-21 H2 run:
| Class | Gap | Extra beans |
|---|---|---|
ServiceCheckStoreTest |
3.21s | ServiceCheckStore |
AffectedApplicationsTest |
3.17s | AffectedApplications, Replace.ANY |
ServiceHealthFilterTest |
1.91s | ServiceHealthQuery |
ServiceAccessSummaryTest |
1.91s | summary and usage beans |
ServiceCheckDispatcherTest |
1.13s | sitmun.service-check.enabled=true |
Two changelog tests are separate and should stay separate. They are slow because the assertion is a fresh H2 plus the master changelog.
ApplicationContactMigrationTest.migrationIsIdempotentAndColumnExistsapplies the changelog three times (11.748s).SequenceMigrationTest.productionChangelogInitializesEveryTableGeneratorAboveSeededIdsapplies it once (7.278s).
Why this is not a test-only edit
Merging the nested imports changes which beans the slice loads. Sharing one migrated database across the changelog tests is a fixture change.
Empty nested @TestConfiguration classes that only imported I18nTestConfiguration are already hoisted to @Import on the test class. Do not reopen that.
Activity
fjlopez commentedon Oct 21, 2026
The empty i18n-only nested
@TestConfigurationclasses are hoisted in the local working tree on top of73840f75. They are not ondevyet. Until that diff lands,HEADstill has the empty nested class, for example inTerritoryRepositoryTest.The five Liquibase slices in this issue still keep a private nested configuration with extra beans. That part is on
devand in the working tree.A later H2 run the same day, 08:04:19Z to 08:06:49Z, measured method time of 5.118s for
ApplicationContactMigrationTestand 3.150s forSequenceMigrationTest. The issue's 11.748s and 7.278s are from the earlier run. Both tests still apply the master changelog. That apply stays.SequenceMigrationTeststill does not checkATR_ID. That hole is #318. It does not change the decision to keep the changelog apply.fjlopez commentedon Oct 21, 2026
Fixed on dev by #350.