Repository navigation
test: assert deleted user returns 404 once - #345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
User create and delete ran twice:
UserResourceTest.createUseron MockMvc andUserResourceIntegrationTest.createNewUserAndDeleteon a real server. Only the server test asserted that GET after delete returns 404, so a broken create or delete failed both.What changed
UserResourceTest.createUsernow GETs the created user after delete and expects 404. The real-server copy of that create and delete is removed.cannotPostWithoutLoginandgetAllUsersstay.Scope
Tests and the
[Unreleased]changelog. No production code, API, or schema change.Blast Radius
The deleted-user 404 check remains, on the MockMvc test. Unauthenticated user creation and the user list stay on the real server.
Verification
./gradlew test --tests org.sitmun.domain.user.UserResourceTest --tests org.sitmun.domain.user.UserResourceIntegrationTestpassed, includingPOST: Create a new user and GET after delete returns 404.spotlessCheck, full./gradlew test, andjacocoTestReport.Fixes #313