Repository navigation
test: lock both owners of membership and role joins (#297) - #352
Merged
Merged
Conversation
PUT of members and memberOf, and of availableRoles and applications, keeps each side as an owning association. Replacing one side leaves the other side's join row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STM_GRP_TERandSTM_APP_ROLstay owning@ManyToManyassociations. This pull request does not mark either sidemappedBy, and it does not change entity mappings, the schema, or Liquibase.TerritoryMembershipAssociationWriteTestlocksPUT /api/territories/{id}/membersandPUT /api/territories/{id}/memberOfastext/uri-list. Each write inserts oneSTM_GRP_TERrow. GET members of the parent contains the child, and GET memberOf of the child contains the parent. Replacing members leaves the member-of row, and replacing memberOf leaves the members row.ApplicationRoleAssociationWriteTestlocks the same two writes and the same non-interference check forPUT /api/applications/{id}/availableRolesandPUT /api/roles/{id}/applicationsonSTM_APP_ROL.Related to #297. The issue stays open.
Test plan
./gradlew test --tests org.sitmun.domain.territory.TerritoryMembershipAssociationWriteTest --tests org.sitmun.domain.application.ApplicationRoleAssociationWriteTest./gradlew spotlessCheck,./gradlew test, and./gradlew jacocoTestReportTerritory.members,Territory.memberOf,Application.availableRoles, andRole.applicationsare unchanged ondev