Repository navigation
test(http): assert proxy body and case rejection - #22
Merged
Merged
Conversation
A lowercase post with a stored body now fails if accept becomes case-insensitive. One XML test checks the stored body. The two header-only XML copies and both disabled JDBC filter methods are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The lowercase method test stayed green if comparison became case-insensitive, because a null body is rejected either way. Three XML tests only checked a fixed content type. Two disabled JDBC tests never applied a filter.
What changed
shouldRejectLowercasePostMethodsupplies a body and expects rejection.shouldHandleXmlBodyWithComplexStructurechecks the stored body. The CDATA and namespace copies are gone.HttpContext. BothjdbcAccessWithFiltersmethods are gone.Scope
Tests only. Production request handling stays as it is. The unused JDBC tester setup stays for the next change.
Blast Radius
These tests run in the proxy module. A case-insensitive
acceptor a dropped request body now fails the suite. Callers of the proxy see no change.Verification
./gradlew test --tests org.sitmun.proxy.middleware.protocols.http.HttpRequestDecoratorAddBodyTest --tests org.sitmun.proxy.middleware.protocols.jdbc.ExecutionRequestExecutorServiceTest --tests org.sitmun.proxy.middleware.service.ExecutionRequestExecutorServiceTestpassed../gradlew test --tests org.sitmun.proxy.middleware.protocols.http.HttpRequestDecoratorAddBodyTest spotlessCheckpassed after the final test rename.