Repository navigation
refactor(http): inline base64 and drop unused test setup - #23
Merged
Merged
Conversation
The JDBC tester initialized a Jackson tester the class does not declare. Basic auth encoding now calls Base64 at its only call site.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The JDBC test class initialized a Jackson tester it does not declare.
encodeAuthorizationonly forwardedBase64.getEncoder().encodeToString.What changed
setup, the Jackson imports, and@TestInstance(Lifecycle.PER_CLASS).Base64.getEncoder().encodeToStringat the only call site.Scope
Dead setup and one forwarder. The trust-all catch in
HttpClientFactoryServicestays.Blast Radius
The encoded header is the same string as before. Proxy callers see no change. The JDBC test still runs one request.
Verification
./gradlew test --tests org.sitmun.proxy.middleware.protocols.jdbc.ExecutionRequestExecutorServiceTest --tests org.sitmun.proxy.middleware.protocols.http.HttpRequestDecoratorAddBasicSecurityTest spotlessCheckpassed.