Repository navigation
docs(http): delete comments that name the wrong protocol - #24
Merged
Merged
Conversation
The feature-count notes call a WFS totalFeatures check a WMS update. The filter-test javadoc calls a WFS GetFeature request a private WMS service.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two notes on a WFS feature count name WMS. The javadoc on the WFS filter test names a private WMS service.
What changed
Updated from 273 to 294notes.privateWfsWithFiltera private WMS service.Scope
Comments only.
HttpRequestDecoratorAddBodyTesthas no feature-count note. Assertions stay.Blast Radius
No runtime change. Reviewers no longer read WMS on a WFS check.
Verification
./gradlew spotlessCheckpassed.git diffis four deleted comment lines.