Repository navigation
docs(proxy): delete narrating comments - #25
Merged
Merged
Conversation
The trust-all setup comments restated the next statement. The notes on the empty certificate checks stay, and the catch is unchanged.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several comments restated the next line. The empty certificate checks stay empty on purpose, and those notes stay.
What changed
checkClientTrustedandcheckServerTrustedstay.Scope
Comments only. The trust-all catch stays.
ProxyUrlBuilderis not in this repository.Blast Radius
No runtime change. The unsafe client still skips certificate checks for the same hosts.
Verification
./gradlew spotlessApply spotlessCheckpassed../gradlew compileJava compileTestJavapassed.