Repository navigation
fix(wfs): keep GeoServer Content-Type off Spring's parser - #28
Merged
Merged
Conversation
Spring 7 re-reads the servlet Content-Type while writing the body. A slash in subtype=gml/2.1.2 became a 500. The response header stays the upstream string.
Mime4j parses the upstream header. Spring sees text/xml and any parameter it can parse. The response keeps the original string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Type: text/xml; subtype=gml/2.1.2no longer becomes a 500 when Spring 7 parses the header while writing the proxied body.Test plan
./gradlew test --tests org.sitmun.proxy.middleware.service.UpstreamContentTypeFilterTest./gradlew spotlessCheckGET /middleware/proxy/12/4/WFS/9401/9401returned 200 withContent-Type: text/xml; subtype=gml/2.1.2