Skip to content

docs(viewer): delete narrating comments - #203

Merged
fjlopez merged 1 commit into
devfrom
cleanup/vw-5-narrating-comments
Oct 15, 2026
Merged

fjlopez merged 1 commit into
devfrom
cleanup/vw-5-narrating-comments

Conversation

@fjlopez

@fjlopez fjlopez commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Why

The viewer comment sweep restates the next statement. // No patches needed repeats requiredPatches = undefined. Two placeholders name no missing behavior. Service comments that state precedence or a runtime shape stay.

What changed

  • Deleted // No patches needed and the threeD // No patches required note on 21 handlers.
  • Deleted restating comments in the layer catalog, feature info, and the control base. The empty fall-through in getRootNodeIds is now if (filtered.length > 0).
  • Deleted step labels in virtual WMS capabilities, the control registry, the SITNA loader, the script loader, the error interceptor, the global error handler, the roles matrix, and config lookup.
  • Deleted restating comments in notification, profile, the navigation bar, login, the error sidebar, dashboard items, the menu, the abstract map, and the app module.
  • Deleted // TODO with specific details and the empty clipboard .then whose only content was // Could show a snackbar here.
  • Kept disabled-versus-backend precedence, the getDefaultValueWhenMissing requirement, the WFSQuery div note, runtime string guards, the leaf Name rule, the empty abstract note, circular-dependency notes, and the map reload and submenu lifetime notes.

Scope

Comments, plus the empty catalog branch and the empty clipboard .then.

Blast Radius

getRootNodeIds still returns the selected root when that tree is non-empty, and still falls through when it is empty. copyError still logs clipboard failure. No other runtime change.

Verification

  • npx jest on virtual-wms-capabilities.service.spec.ts, error-details-sidebar.component.spec.ts, and control-registry.service.spec.ts: 3 suites, 108 tests, exit 0.
  • npm run lint: all files pass linting, exit 0.
  • npm run build: exit 0. Hash bc56590d2e1a41e5.

The comments restated the next line. Precedence, runtime shape, and the no-patch assignments stay.
@fjlopez
fjlopez changed the base branch from cleanup/vw-4-type-escapes to dev October 15, 2026 08:01
@fjlopez

fjlopez commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Reopening so CI runs against dev.

@fjlopez fjlopez closed this Oct 15, 2026
@fjlopez fjlopez reopened this Oct 15, 2026
@fjlopez
fjlopez merged commit 04b8070 into dev Oct 15, 2026
3 checks passed
@fjlopez
fjlopez deleted the cleanup/vw-5-narrating-comments branch October 15, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant