Repository navigation
docs(viewer): delete narrating comments - #203
Merged
Merged
Conversation
The comments restated the next line. Precedence, runtime shape, and the no-patch assignments stay.
Contributor
Author
|
Reopening so CI runs against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The viewer comment sweep restates the next statement.
// No patches neededrepeatsrequiredPatches = undefined. Two placeholders name no missing behavior. Service comments that state precedence or a runtime shape stay.What changed
// No patches neededand the threeD// No patches requirednote on 21 handlers.getRootNodeIdsis nowif (filtered.length > 0).// TODO with specific detailsand the empty clipboard.thenwhose only content was// Could show a snackbar here.getDefaultValueWhenMissingrequirement, the WFSQuerydivnote, runtime string guards, the leafNamerule, the empty abstract note, circular-dependency notes, and the map reload and submenu lifetime notes.Scope
Comments, plus the empty catalog branch and the empty clipboard
.then.Blast Radius
getRootNodeIdsstill returns the selected root when that tree is non-empty, and still falls through when it is empty.copyErrorstill logs clipboard failure. No other runtime change.Verification
npx jestonvirtual-wms-capabilities.service.spec.ts,error-details-sidebar.component.spec.ts, andcontrol-registry.service.spec.ts: 3 suites, 108 tests, exit 0.npm run lint: all files pass linting, exit 0.npm run build: exit 0. Hashbc56590d2e1a41e5.