Repository navigation
fix: Always deactivate OTP even if it is a debug code - #20
Merged
Merged
Conversation
paveldedik
force-pushed
the
pd/fix-otp-debug-deactivation
branch
from
April 2, 2026 11:52
03f2f2a to
e573fba
Compare
paveldedik
force-pushed
the
pd/fix-otp-debug-deactivation
branch
from
April 2, 2026 12:19
e573fba to
5440f72
Compare
paveldedik
commented
Apr 2, 2026
| assert_true(check_authorization_request( | ||
| authorization_request, | ||
| otp_secret_key=authorization_request.secret_key, | ||
| deactivate_otp_on_success=False |
Member
Author
There was a problem hiding this comment.
Without this argument, the test wouldn't work because OTP is deactivated when request is successful by default.
Pull Request Test Coverage Report for Build 23900044384Details
💛 - Coveralls |
dstlmrk
self-requested a review
April 2, 2026 12:27
dstlmrk
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.