Skip to content

fix: Mark stale active task runs as failed instead of expired - #20

Merged
paveldedik merged 2 commits into
masterfrom
pd/fail-killed-task-runs
Oct 21, 2026
Merged

paveldedik merged 2 commits into
masterfrom
pd/fail-killed-task-runs

Conversation

@paveldedik

Copy link
Copy Markdown
Member

No description provided.

When the hard time limit or the OOM killer kills the worker process, the
run log stays active and the stale task sweep expired the invocation as if
the task never ran. The sweep now marks such a run and its invocation as
failed and calls on_task_failure with StaleTaskRunError through the new
LoggedTask.fail_invocation hook.
@paveldedik paveldedik self-assigned this Oct 20, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 39441582973

Coverage increased (+0.5%) to 93.05%

Details

  • Coverage increased (+0.5%) from the base build.
  • Patch coverage: 159 of 159 lines across 4 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4101
Covered Lines: 3816
Line Coverage: 93.05%
Coverage Strength: 1.86 hits per line

💛 - Coveralls

@paveldedik
paveldedik requested a review from rubickcz October 20, 2026 14:57
@paveldedik
paveldedik merged commit d973e14 into master Oct 21, 2026
4 checks passed
@paveldedik
paveldedik deleted the pd/fail-killed-task-runs branch October 21, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants