Add language parameter to International Address Autocomplete - #160
Merged
Merged
Conversation
This was referenced Sep 28, 2026
Merged
Merged
Add language parameter to International Address Autocomplete
smartystreets/smartystreets-java-sdk#95
Merged
Merged
mae-smarty
approved these changes
Sep 30, 2026
mae-smarty
left a comment
mae-smarty
left a comment
Contributor
There was a problem hiding this comment.
Maybe add the language parameter to the example for consistency and to demonstrate it.
andyjohnsonsmarty
requested changes
Oct 1, 2026
| import apiToSDKKeyMap from "../util/apiToSDKKeyMap.js"; | ||
| import { Sender } from "../types.js"; | ||
| import Lookup from "./Lookup.js"; | ||
| import { resolveLanguageMode } from "../international_street/Lookup.js"; |
Contributor
There was a problem hiding this comment.
Needs its own language mode separate from international_street
andyjohnsonsmarty
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the documented
languagequery parameter to the International AddressAutocomplete API in the JavaScript SDK.
The API documents
languagefor autocomplete, but no Smarty SDK implemented it,while every SDK already supported it for International Street. This closes that
gap across all nine SDKs.
Companion pull requests
Tracking task: https://app.clickup.com/t/86bc7x07q