Skip to content

[codex] Close atag speaker prefill decisions - #30

Merged
yolo-sam merged 4 commits into
codex/atag-poller-basefrom
codex/atag-close-questions
May 28, 2026
Merged

yolo-sam merged 4 commits into
codex/atag-poller-basefrom
codex/atag-close-questions

Conversation

@yolo-sam

@yolo-sam yolo-sam commented May 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Convert the leftover PR [codex] Skip atag human label placeholders #29 "unresolved questions" into explicit closed decisions.
  • Add atag-poll.sh --name/--user-name so the poller passes the agent's known human name into atag prompts.
  • Resolve missing names through git user name, GitHub profile name/login, Unix username, then user.
  • Add a scanner-ignored <!--atag:missing-human-name ...--> recovery comment for the final user fallback so agents ask the human to set a durable name.
  • Sync the canonical atag skill text and tests into the plugin copies and active local skill copies.

Decisions

  • Human label: prefer explicit --name; otherwise derive a simple lower-case label from local identity sources.
  • [!DONE]- prefill: no v1 prefill; DONE follow-ups stay append-friendly after <!--atag:eot-->.
  • Placeholder marker: no hidden marker for normal known-name labels; only the final user fallback gets the missing-name recovery comment.
  • Legacy labels: keep compatibility for old bare/colon agent labels and legacy emphasized human-label placeholders.

Verification

  • bash -n skills/atag/scripts/atag-poll.sh
  • bun test skills/atag/reference/markdown-agent-tags.spec.test.ts skills/atag/reference/atag-poll.test.ts - 234 pass, 0 fail
  • scripts/sync-skills.sh
  • diff -qr -x dev skills/atag claude-plugins/atag/skills/atag
  • diff -qr -x dev skills/atag codex-plugins/atag/skills/atag
  • diff -qr -x dev skills/atag /Users/smcllns/Projects/dotfiles/skills/atag
  • diff -qr -x dev skills/atag /Users/smcllns/.agents/skills/atag
  • git diff --check

@yolo-sam
yolo-sam merged commit 632df17 into codex/atag-poller-base May 28, 2026
1 check passed
@yolo-sam
yolo-sam deleted the codex/atag-close-questions branch May 28, 2026 04:07
yolo-sam added a commit that referenced this pull request May 28, 2026
Foreground poller (atag-poll.sh) that scans markdown for unresolved agent tags in [!NOTE]+/[!DONE]- callouts and inline @triggers, plus the inline-code speaker-label protocol with <!--atag:eot--> turn seals. Consolidates the atag-poller epic (#29, #30, #33) and adversarial-review fixes: process-group-correct timeout, no temp-file leak in loop mode, safe relative-path prompt building, documented acceptEdits trust boundary, and trimmed scope. Synced across the 3 in-repo skill copies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants