Repository navigation
Conversation
# Conflicts: # tests/link.bats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes CI green and aims for a warm-cache wall-clock time under 1:30.
Fixes
scripts/link.sh: on macOS/bin/bash3.2 under load,printfcould fail with EINTR when a child exited, which dropped a list line. This was whylink.bats"a second run changes nothing" failed on main: run 1 lost an editor link and run 2 made it. The lists are now collected before they are printed.scripts/doctor.sh: reads link.sh's output through a temp file, for the same EINTR reason.~/.gitconfigor/opt/homebrew, and pass from a checkout under a symlinked path.Speed (coverage unchanged: same
@testcount in every file)link.sh: fewer subshells and processes, output identical across 30 compared commands.link.batsuses about 40% less CPU.bin_scripts.batsis split intobin_scripts,bin_pihole,bin_ph_backup, andbin_firetv, with no real sleeps and mocks written once per file.deps,ai_doctor,doctor,install: fixtures built once, sleeps dropped.CI: five macOS Bats shards (the account's concurrent macOS limit), balanced by measured time. The separate shellcheck job becomes a step in the lightest shard.