Update ChainSetup and IdentityChain interface - #759
Open
arandito wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
ChainSetupto store the resolved profile name instead of a parsed profileSection.Downstream providers (e.g. assume-role) need
ChainSetupto store the resolved profile name for cycle tracking. Storing the parsedSectionalongside it would make the profile reachable two ways,setup.profileandsetup.profile_file.get_profile(setup.profile_name), duplicating state. Usingprofile_nameas the single source of truth lets providers read values consistently throughMergedConfig.get(profile_name, key). That call also performs the string validation the previous_get_stringhelpers provided, so each provider no longer needs its own copy of that logic.This PR also renames
profile_file/profile_name_overridetoconfig_file/profile_namefor consistency, and updates theEcsContainermodule suggestion fromaws-credentials-ecstoaws-credentials-http.Testing
make check-pyandmake test-py.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.