Skip to content

๐Ÿ› ์ค‘์•™๋Œ€ ์Šฌ๋Ÿฌ๊ทธ๊ฐ€ university-web์œผ๋กœ rewrite๋˜์ง€ ์•Š๋˜ ๋ฌธ์ œ ์ˆ˜์ • - #624

Merged
manNomi merged 1 commit into
mainfrom
fix/university-rewrite-chungang-slug
Aug 3, 2026
Merged

๐Ÿ› ์ค‘์•™๋Œ€ ์Šฌ๋Ÿฌ๊ทธ๊ฐ€ university-web์œผ๋กœ rewrite๋˜์ง€ ์•Š๋˜ ๋ฌธ์ œ ์ˆ˜์ •#624
manNomi merged 1 commit into
mainfrom
fix/university-rewrite-chungang-slug

Conversation

@manNomi

@manNomi manNomi commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

๋ฌธ์ œ

https://www.solid-connection.com/university/chungang ์ด 404๋ฅผ ๋ฐ˜ํ™˜ํ•ฉ๋‹ˆ๋‹ค.

/university/inha     -> 200
/university/kyunghee -> 200
/university/chungang -> 404

์›์ธ

apps/web/next.config.mjs์˜ ๋ฉ€ํ‹ฐ์กด rewrite ์Šฌ๋Ÿฌ๊ทธ๊ฐ€ ํ•˜๋“œ์ฝ”๋”ฉ๋˜์–ด ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.

const universitySlugPattern = "(inha|kyunghee)";

์ด ํŒจํ„ด์ด /university/:homeUniversity ์š”์ฒญ์„ university-web์œผ๋กœ ๋„˜๊ธธ์ง€ ๊ฒฐ์ •ํ•ฉ๋‹ˆ๋‹ค. chungang์ด ๋ชฉ๋ก์— ์—†์–ด rewrite๊ฐ€ ๊ฑธ๋ฆฌ์ง€ ์•Š๊ณ , ํ•ด๋‹น ๋ผ์šฐํŠธ๊ฐ€ ์—†๋Š” apps/web์œผ๋กœ ๋–จ์–ด์ ธ 404๊ฐ€ ๋‚ฌ์Šต๋‹ˆ๋‹ค.

#622(์ค‘์•™๋Œ€ ์ถ”๊ฐ€)์—์„œ ๋†“์นœ ๋‘ ๋ฒˆ์งธ ๋“ฑ๋ก ์ง€์ ์ž…๋‹ˆ๋‹ค. ํ™ˆ ๋Œ€ํ•™์€ apps/university-web์˜ ์ƒ์ˆ˜์™€ ์ด rewrite ํŒจํ„ด ๋‘ ๊ณณ์— ๋“ฑ๋ก๋˜์–ด์•ผ ํ•˜๋Š”๋ฐ, ์ „์ž๋งŒ ๋ฐ˜์˜ํ–ˆ์Šต๋‹ˆ๋‹ค.

์ˆ˜์ •

์Šฌ๋Ÿฌ๊ทธ ๋ชฉ๋ก์„ ๋ฐฐ์—ด๋กœ ๋ถ„๋ฆฌํ•˜๊ณ  chungang์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‘ ๊ณณ์„ ํ•จ๊ป˜ ๊ฐฑ์‹ ํ•ด์•ผ ํ•œ๋‹ค๋Š” ์ ์„ ์ฃผ์„์œผ๋กœ ๋ช…์‹œํ–ˆ์Šต๋‹ˆ๋‹ค.

/university/score/*, /university/application/*๋Š” apps/web ์†Œ์œ ์ด๋ฏ€๋กœ ์™€์ผ๋“œ์นด๋“œ ๋Œ€์‹  allowlist ๊ตฌ์กฐ๋ฅผ ์œ ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์‹ค์ œ๋กœ ์ƒ์„ฑ๋˜๋Š” ํŒจํ„ด์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

์„ธ๊ทธ๋จผํŠธ ์ฒ˜๋ฆฌ
inha / kyunghee / chungang university-web์œผ๋กœ rewrite
score / application apps/web ์œ ์ง€

๋ฐฐํฌ ์ˆœ์„œ (์ค‘์š”)

์ด PR ๋จธ์ง€๋งŒ์œผ๋กœ๋Š” ์‚ฌ์ดํŠธ๊ฐ€ ๊ณ ์ณ์ง€์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

  • release-university โ€” main๊ณผ ๋™์ผ, ์ค‘์•™๋Œ€ ํฌํ•จ โœ… (university-web ์ชฝ์€ ์ด๋ฏธ ์ค€๋น„ ์™„๋ฃŒ)
  • release-web โ€” main๋ณด๋‹ค 15์ปค๋ฐ‹ ๋’ค์ฒ˜์ง. rewrite๋ฅผ ์†Œ์œ ํ•œ ์•ฑ์ด๋ผ ์ด ๋ธŒ๋žœ์น˜๊ฐ€ ๊ฐฑ์‹ ๋˜์–ด์•ผ ๋ฐ˜์˜๋ฉ๋‹ˆ๋‹ค.

๋จธ์ง€ ํ›„ Promote Main to Release Branches workflow๋ฅผ web ํƒ€๊นƒ์œผ๋กœ ์‹คํ–‰ํ•ด์•ผ /university/chungang์ด ์—ด๋ฆฝ๋‹ˆ๋‹ค.

๊ฒ€์ฆ

  • pnpm --filter @solid-connect/web run lint:check โ€” ํ†ต๊ณผ (university-zone-navigation ๋ฃฐ ํฌํ•จ)
  • pnpm --filter @solid-connect/web run typecheck โ€” ํ†ต๊ณผ
  • pnpm --filter @solid-connect/web run build โ€” ํ†ต๊ณผ

ํ›„์† ์ œ์•ˆ (์ด PR ๋ฒ”์œ„ ๋ฐ–)

next.config.mjs๊ฐ€ .mjs๋ผ TS ์ƒ์ˆ˜๋ฅผ importํ•  ์ˆ˜ ์—†์–ด ์ˆ˜๋™ ๋™๊ธฐํ™”๊ฐ€ ๋‚จ์•„ ์žˆ์Šต๋‹ˆ๋‹ค. ๊ฐ™์€ ์‚ฌ๊ณ ๊ฐ€ ๋ฐ˜๋ณต๋˜์ง€ ์•Š์œผ๋ ค๋ฉด ์Šฌ๋Ÿฌ๊ทธ ๋ชฉ๋ก์„ ์–‘์ชฝ์ด importํ•  ์ˆ˜ ์žˆ๋Š” ๊ณต์šฉ .mjs ๋ชจ๋“ˆ๋กœ ๋นผ๊ฑฐ๋‚˜, CI์—์„œ ๋‘ ๋ชฉ๋ก์˜ ์ผ์น˜๋ฅผ ๊ฒ€์‚ฌํ•˜๋Š” ํŽธ์ด ์•ˆ์ „ํ•ฉ๋‹ˆ๋‹ค.

๋˜ํ•œ apps/web์˜ HOME_UNIVERSITY_LIST์—๋Š” ์—ฌ์ „ํžˆ ์ค‘์•™๋Œ€๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค(ํ™ˆ ๋ชฉ๋กยทsitemap). maxChoiceCount ๊ฐ’์ด ํ™•์ •๋˜๋ฉด ๋ณ„๋„ PR๋กœ ๋ฐ˜์˜ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๐Ÿค– Generated with Claude Code

@manNomi
manNomi requested a review from wibaek as a code owner August 3, 2026 14:44
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Building Building Preview Aug 3, 2026 2:45pm
solid-connection-web Ready Ready Preview Aug 3, 2026 2:45pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Aug 3, 2026 2:45pm

@github-actions github-actions Bot added the web label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@manNomi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 47a54d26-7636-48ed-99ff-a82feef2037b

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 67d3dc0 and f653b8d.

๐Ÿ“’ Files selected for processing (1)
  • apps/web/next.config.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant