π λν μμΈνμ΄μ§ μ§μ μ€ν¨ μ μ μ μλ¬ ν μ€νΈκ° μ€λ³΅ νμλλ λ¬Έμ μμ - #628
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (1)
WalkthroughEstimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
λ¬Έμ
λν μμΈνμ΄μ§(
/university/:homeUniversity/:id) μ§μ μ λ°μ΄ν° μ‘°νμ μ€ν¨νλ©΄, νλ©΄μλ "λν μ 보λ₯Ό μ€λΉμ€μ λλ€" κ°μ μλ΄κ° μ μμ μΌλ‘ λ¨λλ° λμμ μ μ μλ¬ ν μ€νΈ("μ€λ₯κ° λ°μνμ΅λλ€. λ€μ μλν΄μ£ΌμΈμ.")κΉμ§ ν¨κ» νμλ©λλ€.μμΈ
#623μμ μΆκ°λ CSR ν΄λ°±(
UniversityDetailCsrFallback)μ΄useGetUniversityDetailν (react-query)μ μ°λλ°,apps/university-webμ μ μQueryCache.onError(queryClient.ts)λmeta.skipGlobalErrorToastκ° μλ λͺ¨λ 쿼리 μ€ν¨μ ν μ€νΈλ₯Ό λμλλ€. μ΄ ν μλ κ·Έ λ©νκ° μμ΄μ, ν΄λ°± UIκ° μ€ν¨λ₯Ό μ΄λ―Έ λΆλλ½κ² μλ΄νκ³ μλλ°λ ν μ€νΈκ° μ€λ³΅μΌλ‘ μΉνμ΅λλ€.useGetUniversityDetailμ μ μ₯μ μ 체μμ μ΄ CSR ν΄λ°± ν κ³³μμλ§ μ°μ λλ€ β μ νν "λν μμΈνμ΄μ§ μ§μ μ€ν¨" μλ리μ€μ λλ€.μμ
useGetUniversityDetailμuseQueryμ΅μ μmeta: SKIP_GLOBAL_ERROR_TOAST_METAλ₯Ό μΆκ°νμ΅λλ€.apps/university-webμ μ΄λ―Έ μλ κΈ°μ‘΄ ν¨ν΄(postUploadProfileImage.tsλ±)μ κ·Έλλ‘ λ°λμ΅λλ€.νλ©΄μ 보μ΄λ μλ΄(
UniversityDetailPreparingFallback)λ κ·Έλλ‘ μ μ§λκ³ , μ€λ³΅ ν μ€νΈλ§ μ¬λΌμ§λλ€.κ²μ¦
pnpm --filter @solid-connect/university-web run lint:checkβ 321 files ν΅κ³Όpnpm --filter @solid-connect/university-web run typecheck:ciβ ν΅κ³Όmetaβquery.metaβshouldSkipGlobalErrorToastλ‘ μ΄μ΄μ§λ κ²½λ‘λ₯Ό μ½λλ‘ μ¬νμΈλ²μ λ° (μ°Έκ³ )
κ°μ νμ΄μ§μ λͺ©λ‘ CSR ν΄λ°±(
UniversityListCsrFallback)λ μΈλΌμΈuseQueryλ‘ λμΌν μ μ ν μ€νΈ λ¬Έμ λ₯Ό κ°μ§ μ μμ΅λλ€. λ€λ§ μ΄λ² μμ² λ²μ(μμΈνμ΄μ§)μ λ§μΆ° μ΄ PRμλ ν¬ν¨νμ§ μμμ΅λλ€. νμνμλ©΄ λ³λ PRλ‘ μ²λ¦¬νκ² μ΅λλ€.π€ Generated with Claude Code