Replace esbuild with oxc-parser in file rotues#2199
Open
birkskyum wants to merge 4 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: cd25074 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
birkskyum
requested review from
katywings and
lxsmnsyc
and removed request for
lxsmnsyc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the filesystem router’s esbuild + es-module-lexer pipeline with oxc-parser.
I ran a local bench, and the numbers i see indicate 10-20x performance for file scanning
Bundle size is approx. unchanged
Why
The filesystem router only needs static export metadata to identify page components, route configuration, and HTTP handlers. Previously, every route module was first transformed with esbuild and then scanned with es-module-lexer.
oxc-parser can parse TSX and return static export information directly. This removes an unnecessary transformation step and lets the router consume Oxc’s native StaticExportEntry records.
This also removes esbuild and es-module-lexer as direct dependencies of @solidjs/start.