feat!: move to workflow-engine-core 2.0 - #15
Merged
Merged
Conversation
Core 2.0 is a `fix!` release that corrects silent-success defects, and two of those corrections are visible here: - `WorkflowBuilder::email()` is now `fakeEmail()`, and the step it adds is `FakeEmailAction`. The rename is the point: the old method never sent anything, so a workflow that "emailed" a user silently did nothing. Tests updated to the honest name. - A failed workflow may now transition back to running, so it can be retried. Completed and cancelled remain terminal. The assertion that this was forbidden is inverted, with a note saying why. 74 tests pass against core 2.0.0; Pint clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core 2.0 is a
fix!release correcting silent-success defects. Two of those corrections surface here.WorkflowBuilder::email()is nowfakeEmail(), adding aFakeEmailAction. The rename is the whole point: the old method never sent anything, so a workflow that "emailed" a user silently did nothing. Tests updated to the honest name — this is a breaking change for anyone calling->email(), which is why it isfeat!.A failed workflow can now transition back to running, so it can be retried; completed and cancelled remain terminal. The test asserting that was forbidden is inverted, with a note explaining why rather than just flipping the boolean.
Ready to tag v1.1.0 once merged.
🤖 Generated with Claude Code