Repository navigation
Migrate to Effect 4 and update project tooling - #163
Conversation
samuelbriole
changed the title
| "skipLibCheck": true, // Skip type checking of third party libraries. | ||
| "noErrorTruncation": true, // Do not truncate error messages. | ||
| "types": [], // Disable automatic loading of `@types/*` packages. | ||
| "jsx": "react-jsx", |
There was a problem hiding this comment.
If I'm not mistaken there si no jsx in this repo
| NATSError.JetStreamManagerError, | ||
| NATSConnection.NATSConnection | ||
| > => Layer.scoped(JetStreamManager, makeJetStreamClient(options)) | ||
| > => Layer.effect(JetStreamManager, makeJetStreamClient(options)) |
There was a problem hiding this comment.
No scope anymore? How do we stop the connection?
There was a problem hiding this comment.
actually Layer.effect accepts scoped resource acquisition (check the docs), the connection will stop like before
There was a problem hiding this comment.
Layer.scoped does not exists anymore in v4
|
@samuelbriole just saw that the stable release is out, let's upgrade directly to this version wdyt? |
|
@antonin-morel-spiko Agreed, the PR now uses stable Effect 4.0.0. CI is green, and all 83 tests pass from both sources and built artifacts. |
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| uses: pnpm/action-setup@v6 | ||
| - name: Install node | ||
| uses: actions/setup-node@v6 | ||
| uses: actions/setup-node@v7 |
There was a problem hiding this comment.
I think you dont need to install node when you install pnpm (docs)
|
@samuelbriole let's merge! |
|
@antonin-morel-spiko unfortunately I don't have any rights on this repo anymore If you want we can discuss how to share the ownership of this project |
|
@samuelbriole sent you a sms looks like you didn't get it. Oc let's talk! Sorry I merge a dependabot pr in between this one needs to be rebased. If you're ok I'll merge it when it's ready |
001f020 to
23912ed
Compare
b7efbab to
ff7ca2c
Compare
|
@samuelbriole can I merge? |
2 participants
Summary
Compatibility
Requires Effect 4;
@effect/platformis no longer a peer dependency. Packages are ESM-only with explicit public exports.Validation
CI is green. Build, lint, type checks, and package/declaration validation pass.
All 83 tests pass locally from both sources and built artifacts (
TEST_DIST=1).