Repository navigation
fix: allow merge branch messages without 'into' - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Git omits
into <branch>when merging into the default branch, e.g.Merge branch 'x'. The merge-branch pattern still required it, so these messages were rejected. This was the last commit of #6, which was merged before it was pushed.Fix
Make
into <branch>optional in the merge-branch pattern, alongside the already-optionalof <repo>.Verification
Ran the default pattern against sample messages:
Merge branch 'x',... of a/b,... into f/xand... of a/b into f/xpass; unquoted branch, danglingintoand trailing junk still fail. The action itself and any test suite were not run.