Repository navigation
fix: handle a caller who left before the webhook reply, show the real retry count - #58
Merged
Merged
Conversation
Move the hard-coded chat, reply, menu and HUD messages into a phrase file with en, fr, ru, es, de, pt and chi (srcdslab/.github#5). Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
… retry count Translation audit follow-up (srcdslab/.github#6). Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the disconnected-caller handling and retry-limit messaging updates.
No open issues 🎉
What changed in this PR
Addresses #57 on top of the translation work in #56 by safely handling webhook replies after the caller disconnects and displaying the configured retry limit.
Changes:
- Logs and returns when the caller has left, skipping chat notifications, cooldown updates, and retries.
- Passes the configured retry limit to the resend phrase in all seven languages.
- Bumps the plugin version to 2.3.4.
| File | Description |
|---|---|
| addons/sourcemod/translations/CallAdmin.phrases.txt | Replaces the hard-coded retry limit with a second parameter in all seven languages. |
| addons/sourcemod/scripting/CallAdmin.sp | Adds the disconnected-caller guard, passes the retry limit, and updates the version. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57.
Stacked on #56, this plugin's translation PR: merge #56 first. GitHub then retargets this PR to
master; refresh it by mergingmaster(overlapping lines: keep this branch's side).Changes
OnWebHookExecutedreturns early when the caller is gone, with one log line (userid, HTTP status, reason). No chat message, no cooldown or cookie update, and no retry, becauseSendWebHookneeds the caller to build the embed.{2}(#format{1:d},{2:d}), updated in all 7 languages. The code passesg_cvWebhookRetry.IntValue.Checks
smtranslate check --languages en,fr,ru,es,de,pt,chi: 0 errors, 0 warnings.