Repository navigation
Conversation
- Added lifecycle hooks (onInputStart, onInputDelta, onInputAvailable, onOutput) to various tools for improved observability and logging. - Implemented request context interfaces in multiple tools to support user-specific functionality, including userId and tool-specific preferences. - Updated the fs, github, pdf, and other tools to utilize the new request context and lifecycle hooks. - Removed redundant logging in the GitHub tool and ensured consistent logging practices across all tools. - Created new processor classes (CustomOutputProcessor and DynamicModelProcessor) to handle output transformations and dynamic model selection based on step processing. - Documented the initial concept and product guide for AgentStack, outlining its vision, target audience, and key capabilities. - Added setup state tracking for the product guide completion. - Conducted thorough diagnostics to ensure all tools comply with the new lifecycle and context usage standards.
- Implemented CompanyProfileCard to display company profile information including market cap, website, and description. - Created FinancialQuoteCard to show stock quotes with price, change, and percentage change. - Developed FinancialChart to visualize stock price data using line and area charts. feat: introduce GitHub tools components - Added CommitHistoryList to display recent commits with author information and commit messages. - Created RepositoryCard to list repositories with details like stars, forks, and last updated date. - Implemented PullRequestList to show pull requests with state and labels. - Developed IssueCard to fetch and display issue details including comments and labels. feat: implement research tools components - Added NewsCarousel to display news articles with source, date, and snippets. - Created ArxivPaperCard to show research papers with authors, publication date, and PDF links. - Implemented SearchResultList to display search results with links and snippets. feat: add weather tool components - Developed WeatherCard to show current weather conditions and a 7-day forecast. - Implemented ForecastView to display detailed weather forecast for multiple days. docs: add continuity session notes for reference - Created CONTINUITY_ses_4603.md to document the session and reference the web-scraper-tool.tsx for patterns.
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @ssdeanx, your pull request is larger than the review limit of 150000 diff characters
|
🤖 Hi @ssdeanx, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
Caution Review failedThe pull request is closed. Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis pull request introduces custom UI components for rendering Mastra tool outputs, adds lifecycle hooks and request context typing across tool modules, updates agent configurations with automatic suspended tool resumption, expands documentation with conductor guides and style standards, and reorganizes the llms.txt reference index. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (78)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
🤖 I'm sorry @ssdeanx, but I was unable to process your request. Please see the logs for more details. |
Summary of ChangesHello @ssdeanx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the project's frontend by integrating advanced, interactive UI components for AI tools, transforming how users visualize and interact with data from financial, GitHub, weather, and research services. Concurrently, it establishes a robust documentation foundation with detailed style guides, product vision, and development workflows, ensuring consistency and clarity across the project. These changes are complemented by internal refinements to agent and tool configurations, enhancing their robustness and observability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly expands the project's AI agent capabilities and user interface by introducing a suite of new UI components for various Mastra tools, including financial data, GitHub interactions, weather forecasts, and research/search results. The core change involves updating app/chat/components/agent-tools.tsx to dynamically render these specialized React components (FinancialQuoteCard, FinancialChart, CompanyProfileCard, RepositoryCard, PullRequestList, IssueCard, CommitHistoryList, WeatherCard, ForecastView, ArxivPaperCard, NewsCarousel, SearchResultList) based on the tool being invoked, replacing generic JSON outputs with rich, interactive elements. Corresponding unit tests for these new UI components have been added, and the project's documentation (llms.txt, conductor/*.md files) has been extensively updated to reflect the expanded feature set, technology stack, product vision, and development workflow, including new code style guides. Additionally, several Mastra tool files (data-file-manager.ts, data-processing-tools.ts, data-validator.tool.ts, diff-review.tool.ts, editor-agent-tool.ts, evaluateResultTool.ts, execa-tool.ts, extractLearningsTool.ts, financial-chart-tools.ts, find-references.tool.ts, find-symbol.tool.ts, finnhub-tools.ts, fs.ts, github.ts, pdf-data-conversion.tool.ts, pdf.ts, pnpm-tool.ts, polygon-tools.ts, serpapi-academic-local.tool.ts, serpapi-news-trends.tool.ts, serpapi-search.tool.ts, test-generator.tool.ts, web-scraper-tool.ts) have been refactored to consistently use type RequestContext for improved type safety and to ensure all lifecycle hooks (onInputStart, onInputDelta, onInputAvailable, onOutput) are correctly implemented and logged after the execute function, with abortSignal checks and proper requestContext casting. A new E2bSandboxTool UI component was also added, and many agent configurations were updated to include autoResumeSuspendedTools: true in their defaultOptions.
| 'Search Yelp for local businesses and reviews. Requires location parameter. Filter by price range, open now status, and sort by recommended, rating, or review count. Returns business name, rating, reviews, address, phone, hours, and photos. Best for finding local services and restaurants.', | ||
| inputSchema: yelpSearchInputSchema, | ||
| outputSchema: yelpSearchOutputSchema, | ||
| execute: async (input, context) => { |
There was a problem hiding this comment.
The outputSchema property was removed from the yelpSearchTool definition. This is a required property for createTool and its absence will likely cause runtime errors or validation failures. The yelpSearchOutputSchema is defined just above, so it seems this was an accidental deletion.
inputSchema: yelpSearchInputSchema,
outputSchema: yelpSearchOutputSchema,| if ((toolName === "finnhub-company" || toolName === "polygon-stock-fundamentals") && hasOutput) { | ||
| return ( | ||
| <CompanyProfileCard | ||
| key={`${id}-${toolName}-${toolState}-${groupIdx}`} | ||
| toolCallId={id} | ||
| input={latest.input as any} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| if (toolName === "github-list-commits" && hasOutput) { | ||
| return ( | ||
| <CommitHistoryList | ||
| key={`${id}-${toolName}-${toolState}-${groupIdx}`} | ||
| toolCallId={id} | ||
| input={latest.input as any} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| if (toolName === "weatherTool" && hasOutput) { | ||
| return ( | ||
| <div key={`${id}-${toolName}-${toolState}-${groupIdx}`} className="space-y-2"> | ||
| <WeatherCard | ||
| toolCallId={id} | ||
| input={latest.input as { location: string }} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| <ForecastView | ||
| toolCallId={id} | ||
| input={latest.input as { location: string }} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| if ((toolName === "serpapi-news-trends" || toolName === "finnhub-company-news") && hasOutput) { | ||
| return ( | ||
| <NewsCarousel | ||
| key={`${id}-${toolName}-${toolState}-${groupIdx}`} | ||
| toolCallId={id} | ||
| input={latest.input as any} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| if (toolName === "arxiv-search" && hasOutput) { | ||
| return ( | ||
| <ArxivPaperCard | ||
| key={`${id}-${toolName}-${toolState}-${groupIdx}`} | ||
| toolCallId={id} | ||
| input={latest.input as any} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| if (toolName === "serpapi-search" && hasOutput) { | ||
| return ( | ||
| <SearchResultList | ||
| key={`${id}-${toolName}-${toolState}-${groupIdx}`} | ||
| toolCallId={id} | ||
| input={latest.input as any} | ||
| output={latest.output as any} | ||
| errorText={errorText} | ||
| /> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Several components are being passed props cast to any, which undermines the benefits of TypeScript and can lead to runtime errors. You have already imported specific UI tool types at the top of the file, which should be used to ensure type safety.
Specifically, the following components are affected:
CompanyProfileCard(lines 232-233)CommitHistoryList(lines 244-245)WeatherCardandForecastView(output on lines 257, 263)NewsCarousel(lines 275-276)ArxivPaperCard(lines 287-288)SearchResultList(lines 299-300)
If tools have slightly different input/output shapes, you can use a union type to handle them correctly.
For example, for CompanyProfileCard:
// Assuming PolygonStockFundamentalsUITool type is available
input={latest.input as FinnhubCompanyUITool['input'] | PolygonStockFundamentalsUITool['input']}
output={latest.output as FinnhubCompanyUITool['output'] | PolygonStockFundamentalsUITool['output']}Applying this pattern to all the listed components will significantly improve type safety and code quality.
| validatorContext: unknown | ||
| }> // TODO: unknown is not a type | ||
| const requestContext = context?.requestContext as DataValidatorContext | undefined | ||
|
|
There was a problem hiding this comment.
You've defined a typed DataValidatorContext interface, which is a great improvement for type safety. However, you are still using requestContext?.get('validatorContext') to access the context property.
Other files in this pull request (like pnpm-tool.ts) have been updated to access context properties directly (e.g., requestContext?.pnpmToolContext). To maintain consistency and fully leverage the typed interface, you should access the property directly here as well.
| const config = requestContext?.validatorContext |
| const abortSignal = context?.abortSignal | ||
|
|
||
| // Check if operation was already cancelled | ||
| const requestContext = context?.requestContext as FsToolContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared but never used. Please remove it to avoid dead code and keep the function clean.
| }, | ||
|
|
||
| execute: async (inputData, context) => { | ||
| const requestContext = context?.requestContext as GithubToolContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared in the execute function for listRepositories but is never used. This pattern is repeated for all other tools in this file (listPullRequests, listCommits, getIssue, etc.).
Please remove these unused variables to improve code clarity. If you plan to use them in the future, consider adding a // TODO comment explaining the intended use.
| execute: async (inputData, context) => { | ||
| const startTime = Date.now() | ||
| logToolExecution('pdf-to-markdown', { input: inputData }) | ||
| const requestContext = context?.requestContext as PdfDataConversionContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared but never used. Please remove it to keep the code clean.
| }, | ||
| execute: async (inputData, context) => { | ||
| const writer = context?.writer | ||
| const requestContext = context?.requestContext as PdfToolContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared but never used. Please remove it to avoid dead code.
| validateSerpApiKey() | ||
| const writer = context?.writer | ||
| const abortSignal = context?.abortSignal | ||
| const requestContext = context?.requestContext as SerpApiContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared but never used in googleScholarTool. This is also the case for googleFinanceTool (line 305) and yelpSearchTool (line 444). Please remove these unused variables to improve code clarity.
| }, | ||
| execute: async (input, context) => { | ||
| const writer = context?.writer | ||
| const requestContext = context?.requestContext as SerpApiContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared in googleNewsTool but is never used. Please remove it to keep the code clean.
| validateSerpApiKey() | ||
| const writer = context?.writer | ||
| const abortSignal = context?.abortSignal | ||
| const requestContext = context?.requestContext as SerpApiContext | undefined |
There was a problem hiding this comment.
The requestContext variable is declared in googleSearchTool (line 105) and googleAiOverviewTool (line 381) but is never used. Please remove these unused variables.
There was a problem hiding this comment.
Pull request overview
This pull request implements a comprehensive set of changes across multiple areas of the codebase:
Purpose: The PR adds custom AI UI components for Mastra tools, standardizes tool lifecycle hooks and RequestContext usage, configures agent default options, introduces new processor files, adds extensive test coverage for UI components, and establishes a conductor workflow system for project management.
Key Changes:
- Tool Standardization: Moves lifecycle hooks (onInputStart, onInputDelta, onInputAvailable, onOutput) to appear after the execute function in 15+ tool files, and adds RequestContext interfaces with userId fields to improve observability
- UI Component Development: Creates new React components for financial tools, GitHub tools, weather tools, and research tools with corresponding test files, enhancing the chat interface with rich visualizations
- Agent Configuration: Adds
autoResumeSuspendedTools: trueto defaultOptions across 20+ agent files for improved agent behavior
Reviewed changes
Copilot reviewed 78 out of 79 changed files in this pull request and generated 129 comments.
Show a summary per file
| File | Description |
|---|---|
| thoughts/ledgers/*.md | Session continuity logs documenting tool investigation and improvements |
| src/mastra/tools/*.ts | Lifecycle hook repositioning and RequestContext additions for improved tool observability |
| src/components/ai-elements/tools/*.tsx | New UI components for financial, GitHub, weather, and research tools |
| src/components/ai-elements/tools/tests/*.test.tsx | Comprehensive test coverage for new UI components |
| src/mastra/agents/*.ts | Addition of defaultOptions with autoResumeSuspendedTools flag |
| src/mastra/processors/*.ts | New processor implementations for dynamic models and custom outputs |
| src/mastra/config/lance.ts | Syntax fix (missing closing quote) |
| package.json & package-lock.json | Addition of @testing-library/react dependency |
| conductor/* | New conductor workflow system with plans, specs, and style guides |
| llms.txt | Comprehensive documentation update reflecting new project structure |
|
|
||
| async processOutputResult({ | ||
| messages, | ||
| context, |
There was a problem hiding this comment.
'context' is defined but never used.
|
|
||
| async processOutputStream({ | ||
| stream, | ||
| context, |
There was a problem hiding this comment.
'context' is defined but never used.
|
|
||
| async processInputStep({ | ||
| stepNumber, | ||
| model, |
There was a problem hiding this comment.
'model' is defined but never used.
| async processInputStep({ | ||
| stepNumber, | ||
| model, | ||
| toolChoice, |
There was a problem hiding this comment.
'toolChoice' is defined but never used.
| stepNumber, | ||
| model, | ||
| toolChoice, | ||
| messageList, |
There was a problem hiding this comment.
'messageList' is defined but never used.
| import { Button } from '@/ui/button' | ||
| import { Input } from '@/ui/input' | ||
| import { Label } from '@/ui/label' | ||
| import { Textarea } from '@/ui/textarea' |
There was a problem hiding this comment.
Unused import Textarea.
| import { | ||
| Select, | ||
| SelectContent, | ||
| SelectItem, | ||
| SelectTrigger, | ||
| SelectValue, | ||
| } from '@/ui/select' |
There was a problem hiding this comment.
Unused imports Select, SelectContent, SelectItem, SelectTrigger, SelectValue.
| import { | ||
| FileText, | ||
| Folder, | ||
| Terminal, | ||
| Code, | ||
| Play, | ||
| Upload, | ||
| Download, | ||
| Trash2, | ||
| Eye, | ||
| HardDrive, | ||
| } from 'lucide-react' |
There was a problem hiding this comment.
Unused imports Code, Download, Eye, HardDrive, Play, Trash2, Upload.
|
|
||
| import { Badge } from "@/ui/badge" | ||
| import { Card, CardContent, CardHeader, CardTitle } from "@/ui/card" | ||
| import { TrendingDown, TrendingUp, DollarSign, AlertCircle, Loader2, LineChart as LineChartIcon, Building2, Globe, Users } from "lucide-react" |
There was a problem hiding this comment.
Unused imports Building2, Users.
| import { Card, CardContent, CardHeader, CardTitle } from "@/ui/card" | ||
| import { BookOpen, Search, ExternalLink, User, Calendar, AlertCircle, Loader2, Newspaper } from "lucide-react" | ||
| import { ScrollArea } from "@/ui/scroll-area" | ||
| import { Badge } from "@/ui/badge" |
There was a problem hiding this comment.
Unused import Badge.
No description provided.