Skip to content

feat: add comprehensive tests for url-tool and write-note tool #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssdeanx merged 1 commit into from
Jan 13, 2026
Merged

feat: add comprehensive tests for url-tool and write-note tool #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/tracing-configuration-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,61 +74,81 @@ interface ConfigSelectorOptions {
## Registry Methods

### registerInstance

```typescript
registerInstance(name: string, instance: ObservabilityInstance, isDefault?: boolean): void;
```

Registers an observability instance in the registry.

### getInstance

```typescript
getInstance(name: string): ObservabilityInstance | undefined;
```

Retrieves an observability instance by name.

### getDefaultInstance

```typescript
getDefaultInstance(): ObservabilityInstance | undefined;
```

Returns the default observability instance.

### getSelectedInstance

```typescript
getSelectedInstance(options: ConfigSelectorOptions): ObservabilityInstance | undefined;
```

Returns the observability instance selected by the config selector or default.

### listInstances

```typescript
listInstances(): ReadonlyMap<string, ObservabilityInstance>;
```

Returns all registered observability instances.

### hasInstance

```typescript
hasInstance(name: string): boolean;
```

Checks if an observability instance exists.

### setConfigSelector

```typescript
setConfigSelector(selector: ConfigSelector): void;
```

Sets the config selector function.

### unregisterInstance

```typescript
unregisterInstance(name: string): boolean;
```

Removes an observability instance from the registry.

### clear

```typescript
clear(): void;
```

Clears all instances without shutdown.

### shutdown

```typescript
async shutdown(): Promise<void>;
```

Shuts down all observability instances and clears the registry.
1 change: 1 addition & 0 deletions dot/tests/test-results/test-results.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"numTotalTestSuites":0,"numPassedTestSuites":0,"numFailedTestSuites":0,"numPendingTestSuites":0,"numTotalTests":0,"numPassedTests":0,"numFailedTests":0,"numPendingTests":0,"numTodoTests":0,"snapshot":{"added":0,"failure":false,"filesAdded":0,"filesRemoved":0,"filesRemovedList":[],"filesUnmatched":0,"filesUpdated":0,"matched":0,"total":0,"unchecked":0,"uncheckedKeysByFile":[],"unmatched":0,"updated":0,"didUpdate":false},"startTime":1768217443502,"success":false,"testResults":[]}

@coderabbitai coderabbitai Bot Jan 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if test-results paths are already in .gitignore
echo "=== Checking .gitignore for test-results patterns ==="
if [ -f .gitignore ]; then
  grep -n "test-results" .gitignore || echo "No test-results pattern found in .gitignore"
else
  echo ".gitignore file not found"
fi

# Check for similar test result files
echo ""
echo "=== Looking for similar test result files ==="
fd -t f "test-results" --exclude node_modules || echo "fd command failed, trying find"

# List all files in the test directory
echo ""
echo "=== Contents of dot/tests directory ==="
find dot/tests -type f 2>/dev/null | head -20

# Check .gitignore contents
echo ""
echo "=== Full .gitignore contents ==="
cat .gitignore

Repository: ssdeanx/AgentStack

Length of output: 2724

🏁 Script executed:

#!/bin/bash
# Check if these test-results files are recently added
echo "=== Git status of test-results files ==="
git status dot/tests/test-results/test-results.json tests/test-results/test-results.json 2>/dev/null || echo "Not in git status"

# Check git history
echo ""
echo "=== Recent commits affecting test-results ==="
git log --oneline --all -- "*test-results*" 2>/dev/null | head -5 || echo "Unable to check git log"

# Verify the files contain test output (not schema)
echo ""
echo "=== File contents verification ==="
echo "dot/tests/test-results/test-results.json size:"
wc -c < dot/tests/test-results/test-results.json
echo ""
echo "tests/test-results/test-results.json size:"
wc -c < tests/test-results/test-results.json

Repository: ssdeanx/AgentStack

Length of output: 922

Generated test results files should not be committed to version control.

These appear to be generated test output files with zero tests and are not currently in .gitignore. Generated test artifacts change on every test run and can cause merge conflicts.

Two instances found:

  • dot/tests/test-results/test-results.json
  • tests/test-results/test-results.json

Add to .gitignore:

# Testing
coverage/
+test-results/
🤖 Prompt for AI Agents 
In @dot/tests/test-results/test-results.json at line 1, These test-result JSON
files are generated and should be ignored; add entries for the two paths (e.g.,
"tests/test-results/" and "dot/tests/test-results/" or a generic
"*/test-results/" or "test-results/*.json") to .gitignore, then remove the
currently tracked files from Git (git rm --cached) and commit the .gitignore
change so files like dot/tests/test-results/test-results.json and
tests/test-results/test-results.json are no longer tracked; ensure you do not
delete local files so CI/local runs still produce them.

Loading
Loading