Skip to content

Fix RespawnPacket import order to unblock the Velocity-CTD sync build - #24

Merged
ssquadteam merged 1 commit into
mainfrom
fix/checkstyle-13.11-import-order
Aug 21, 2026
Merged

Fix RespawnPacket import order to unblock the Velocity-CTD sync build#24
ssquadteam merged 1 commit into
mainfrom
fix/checkstyle-13.11-import-order

Conversation

@ssquadteam

Copy link
Copy Markdown
Owner

Resolves #23.

The automated Velocity-CTD libdeflate sync merged abfbb372de41480b93cb31b2400c7a304998083d cleanly, but ./gradlew build failed on the merged tree, so no pull request was opened.

Cause

The merge only carried three dependency bumps in gradle/libs.versions.toml — no code changes:

  • spotless 8.9.08.10.0
  • checkstyle 13.10.013.11.0
  • guava 33.6.0-jre33.7.0-jre

The failing task is :velocity-proxy:checkstyleMain, which reports two CustomImportOrderCheck warnings in BackendPlaySessionHandler.java. Because velocity-checkstyle.gradle.kts sets maxWarnings = 0, those warnings fail the build:

Wrong lexicographical order for 'com.velocitypowered.proxy.protocol.packet.ResourcePackRequestPacket' import.
Should be before 'com.velocitypowered.proxy.protocol.packet.RespawnPacket'.

The RespawnPacket import was added ahead of the ResourcePack* imports. That is the wrong slot — Resp sorts after Reso in ASCII — and checkstyle 13.11.0 tightened CustomImportOrderCheck so it now flags what 13.10.0 let through. The defect is on main; the sync merge only exposed it.

Fix

Move the RespawnPacket import below ResourcePackResponsePacket. One line, no behaviour change.

Verification

  • ./gradlew build on this branch (checkstyle 13.10.0): BUILD SUCCESSFUL, :velocity-proxy:checkstyleMain executed fresh.
  • ./gradlew build on main + the libdeflate merge + this fix (checkstyle 13.11.0): BUILD SUCCESSFUL, :velocity-proxy:checkstyleMain and :velocity-proxy:test both executed fresh.

Once this lands on main, the next upstream-sync run should merge libdeflate and open its pull request normally.

@ssquadteam
ssquadteam merged commit a6e94c8 into main Aug 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream sync: build failed after merging Velocity-CTD libdeflate

1 participant