Skip to content

refactor: Extract apply step (Applier) and move secret creation - #828

Merged
adwk67 merged 5 commits into
mainfrom
feat/smooth-operator/extract-apply-step
Jul 30, 2026
Merged

refactor: Extract apply step (Applier) and move secret creation#828
adwk67 merged 5 commits into
mainfrom
feat/smooth-operator/extract-apply-step

Conversation

@adwk67

@adwk67 adwk67 commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR covers the following:

  • extracts an Apply step
  • moves secret creation to the apply step
  • makes the build step infallible N.B. this involves moving some "builds" to the validate step so that any errors can be thrown there, leaving "build" free to assert validated and non-rejectablle inputs
  • moves object_meta out of the validated cluster code (missed on the last iteration of PRs)
  • ensure correct label versions are used in the tests (ditto)
--- PASS: kuttl (518.41s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-kubernetes (495.63s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-celery (518.39s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67
adwk67 marked this pull request as ready for review July 28, 2026 13:01
@adwk67 adwk67 self-assigned this Jul 28, 2026
@siegfriedweber
siegfriedweber self-requested a review July 28, 2026 13:54
siegfriedweber
siegfriedweber requested changes Jul 29, 2026
View reviewed changes

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review

Comment thread rust/operator-binary/src/controller/build/properties/webserver_config.rs Outdated
siegfriedweber
siegfriedweber requested changes Jul 29, 2026
View reviewed changes
Comment thread rust/operator-binary/src/controller/build/resource/config_map.rs Outdated
Comment thread rust/operator-binary/src/controller/build/resource/executor.rs Outdated
Comment thread rust/operator-binary/src/controller/build/graceful_shutdown.rs Outdated
Comment thread rust/operator-binary/src/controller/validate.rs Outdated
Comment thread rust/operator-binary/src/controller/validate.rs Outdated
@adwk67
refactor: move object_meta into the build step
36494ee 
Functions which build Kubernetes resources or parts of them belong in
the build step, so object_meta becomes a free function in build (the
same shape the other operators settled on after review). Also relocates
the app_version_label test fixture next to its consumers and imports
build_rolegroup_config_map as an item for consistency.

(cherry picked from commit 76187c3)
@adwk67
adwk67 force-pushed the feat/smooth-operator/extract-apply-step branch from b554d5a to 36494ee Compare July 29, 2026 15:49
@adwk67

adwk67 commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

Re-ran smoke tests:

--- PASS: kuttl (536.71s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-celery (516.05s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-kubernetes (536.70s)
PASS

@adwk67 adwk67 mentioned this pull request Jul 30, 2026
Open
12 tasks
siegfriedweber
siegfriedweber approved these changes Jul 30, 2026
View reviewed changes

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67
adwk67 added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 89c6c31 Jul 30, 2026
18 checks passed
@adwk67
adwk67 deleted the feat/smooth-operator/extract-apply-step branch July 30, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@adwk67 adwk67

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adwk67 @siegfriedweber