feat: add native Anthropic support to ToolHive gateway - #1339
Conversation
8236635 to
bb9b5a5
Compare
Cursory review (Standards + Spec)Fully or partially written by an AI agent. Two-axis review of StandardsHard violations
Judgement-call smells
Spec(a) Missing/partial: None found. All three acceptance scenarios (registration, discovery-path derivation, metadata threading, shared token source, transport stripping, independent outcomes, default compatibility, status/UI presentation) have direct test coverage, including the requirement to carry output/thinking limits into the emitted Anthropic (b) Scope creep — The spec asks for concurrent fetch only across the ToolHive pair ("Fetch both ToolHive protocol entries concurrently under the existing operation-wide bounds"). (c) Implemented-but-questionable: Same fragile substring-match flagged under Standards — Summary: Standards — 1 hard violation (missing tracker update) + 4 judgement-call smells, worst being the hint-string coupling between Worth a decision: was widening background/on-demand refresh concurrency to all providers (not just ToolHive) intentional? If so, it probably deserves its own test coverage and a line in the ADR/acceptance doc; if not, scope it back to the ToolHive pair. |
kantord
left a comment
There was a problem hiding this comment.
sorry, see the comments above
bb9b5a5 to
2113e55
Compare
|
Addressed the review findings in the rebased branch:
The app and TUI keep package-local ToolHive-family predicates because the TUI cannot import Verified with |
2113e55 to
7674de7
Compare
|
Rebased onto current
Verified with |
Co-Authored-By: OpenAI Codex <codex@openai.com> Signed-off-by: Samuele Verzi <samu@stacklok.com>
7674de7 to
ff721eb
Compare
Summary
toolhive-anthropicas a distinct native Anthropic Messages provider while preservingtoolhiveas the OpenAI Responses defaultProtocols
toolhive:GET /v1/models,POST /v1/responsestoolhive-anthropic:GET /anthropic/v1/models,POST /anthropic/v1/messagesVerification
task fmttask docstask site:buildtask api:checktask linttask testgo run ./cmd/mecademointernal/appandcmd/mecatui/uiteststask ac-trace-strictcurrently stops on the pre-existingdocs/acceptance/callmcpwithquery-broker-support.mdstatusproposed, which the checker does not recognize.