docs: plan isolated Redis follow capacity - #1422
Open
samuv wants to merge 2 commits into
Open
Conversation
Signed-off-by: Samuele Verzi <samu@stacklok.com>
Signed-off-by: Samuele Verzi <samu@stacklok.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
watch_capacityGo/server/TypeScript contract, mecak8s CLI and Helm defaults, and the narrow ADR 0240 supersession needed to force-close follow clients safely.Development stage
and the in-PR plan declares
**Expected tasks:** 1, a non-placeholder**Combined rationale:**, and no runtime/public/operator/persistence/trust-boundaryinterface change (
None — rationale; workflow-only meta-changes may review processdocs/skills here)
Contract linkage
Interface conformance
port.ErrEventFollowCapacityand stablewatch_capacitymapping; gRPC usesRESOURCE_EXHAUSTED, while the HTTP watch retains200and emits a terminal SSE error frame.WatchConnectionresumeswatch_capacityfrom its last processed cursor;MECATL_ERROR_CODESadds the stable code without a new error class.--redis-follow-pool-sizeand--redis-max-followers, both default 32; Helm addsredis.follow.poolSizeandredis.follow.maxFollowerswith the same defaults.1 ≤ maxFollowers ≤ poolSize.Issue relationship
Relates to #876
Type of change
Test plan
Baseline checks
task lint)task test)go run ./cmd/mecademo)task docs)task site:build)task api:check)task api:update+engine/CHANGELOG.mdtask ac-trace-strict)/panel-reviewPlan-only checks completed:
bash .claude/skills/to-acceptance-plan/scripts/check-acceptance-plan.sh docs/acceptance/redis-follow-capacity.mdbash .claude/skills/to-acceptance-plan/scripts/check-acceptance-plan-test.shtask docsdevils-advocatepass, with all six correctness findings folded into the contractRuntime, API-update, site, and panel gates belong to the implementation PR.
Changes
docs/acceptance/redis-follow-capacity.mddocs/adr/0328-isolated-redis-follow-capacity.mddocs/acceptance/README.md,docs/adr/README.mdUser-facing change
None yet. This PR defines the reviewed contract; implementation follows only after merge.
Special notes for reviewers
Please focus on the two separate bounds (
poolSizeversusmaxFollowers), per-cycle credential-generation leasing, the admission/Close race, TypeScript reconnect behavior, and ADR 0328's narrow supersession of ADR 0240 for isolated follow clients only.The implementation will use the released
github.com/stacklok/toolhive-corev0.0.46redisconnAPI.