Skip to content
This repository was archived by the owner on Aug 28, 2026. It is now read-only.
This repository was archived by the owner on Aug 28, 2026. It is now read-only.

fix(auth): make OIDC_PROVIDER_ID explicitly required or validate at startup #495

Description

@peppescg

Problem

OIDC_PROVIDER_ID has a fallback default of "oidc" in src/lib/auth/constants.ts:

export const OIDC_PROVIDER_ID = process.env.OIDC_PROVIDER_ID || "oidc";

This value is interpolated directly into the OAuth2 callback URL:

redirectURI: `${BASE_URL}/api/auth/oauth2/callback/${OIDC_PROVIDER_ID}`,

In production, if the operator forgets to set OIDC_PROVIDER_ID, the callback URL becomes /api/auth/oauth2/callback/oidc — which won't match what's registered in the OIDC provider (e.g. Okta expects /api/auth/oauth2/callback/okta). This causes a silent redirect URI mismatch that is hard to debug.

The documentation marks this variable as "Required" but the code silently falls back to a default, creating a gap between documented and actual behavior.

Proposal

Either:

  1. Validate at startup — fail fast if OIDC_PROVIDER_ID is not set in production (NODE_ENV === "production"), with a clear error message
  2. Or remove the default and make it truly required (the app won't start without it)

Option 1 is preferred since it preserves the dev experience (default "oidc" works with the mock provider).

Additional context

  • The providerId is also used in the database to associate user accounts with the OIDC provider (db.ts:60). Changing the value after users exist would orphan their accounts.
  • The E2E and dev setups already set this explicitly ("oidc" in workflows, "okta" in Playwright config).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions