Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
Contributor
Author
reyortiz3
added a commit
that referenced
this pull request
Sep 11, 2026
* Detect stale nested-module pins before release validate-release.sh only checked that a required redisconn/* tag existed, not that the pinned version still matches the current tree. #287 changed redisconn's Config without bumping its tag, so root releases v0.0.44-v0.0.46 shipped referencing a stale, incompatible redisconn v0.0.1 via the module proxy. Also wire test-validate-release.sh into CI; it previously ran only through the local Taskfile. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Drop dev-only replace directives in redisconn providers Renovate already bumped the redisconn requirement in these manifests to the released v0.0.2 (#293), which was the only part of #292 not already applied; folding in the remaining replace-directive removal here supersedes that PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Revert "Drop dev-only replace directives in redisconn providers" This reverts commit de2b2a0. --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redisconngainedConfig.PoolSize/Config.MaxActiveConnsin #287, but the root module'srequireforredisconnwas never bumped pastv0.0.1, and the provider submodules (redisconn/aws,redisconn/azure,redisconn/gcp) still pinnedredisconn v0.0.1with a dev-onlyreplacedirective. Since Go ignores a dependency's ownreplacedirectives, every downstream consumer resolvingtoolhive-core(root module v0.0.44 through v0.0.46) via the module proxy gets the staleredisconn v0.0.1package content, andredis/config.go's reference to the newPoolSize/MaxActiveConnsfields fails to compile.This follows the release ordering documented in
docs/redisconn-extraction.md:redisconn/v0.0.2at the currentmainHEAD (no code change needed there — the fields already exist).redisconnrequirement to the releasedv0.0.2and removes the development-only localreplacedirective.Once merged, each provider module will be tagged
redisconn/aws/v0.0.2,redisconn/azure/v0.0.2,redisconn/gcp/v0.0.2, and then the root module will get a release-preparation commit pinning all four to their released versions (removing the remaining dev replaces) ahead of av0.0.47tag.Test plan
GOWORK=off go build ./...andGOWORK=off go test ./...in each ofredisconn/aws,redisconn/azure,redisconn/gcp, resolving the real publishedredisconn v0.0.2from the module proxy (not the local replace).🤖 Generated with Claude Code