Skip to content

Fix early-readiness version check for ACS 4.9 - #270

Merged
vladbologa merged 1 commit into
mainfrom
vb/early-readiness-version-fix
Aug 14, 2026
Merged

Fix early-readiness version check for ACS 4.9#270
vladbologa merged 1 commit into
mainfrom
vb/early-readiness-version-fix

Conversation

@vladbologa

@vladbologa vladbologa commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Fix for issue #269

It appears that the condition >=4.9 was wrong:

So it looks like the feature was first shipped in ACS 4.10.0, not 4.9.0

Copilot AI lite review requested due to automatic review settings August 14, 2026 07:01
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: aa5fae59-dcfc-4402-b3d5-e0c1da458b5b

📥 Commits

Reviewing files that changed from the base of the PR and between 9cda217 and 539343d.

📒 Files selected for processing (1)
  • internal/stackroxversions/constraints.go

📝 Walkthrough

Walkthrough

The change raises the minimum supported operator version for additional printer columns from 4.9.0 to 4.10.0 and updates the related documentation.

Changes

Additional Printer Columns Version Support

Layer / File(s) Summary
Update version constraint and documentation
internal/stackroxversions/constraints.go
The exported version constraint now requires operator versions >= 4.10.0. The documentation states the same minimum version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 53934

This is a localized version-check change with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the version-check fix for ACS 4.9, which matches the change to raise the minimum supported version to 4.10.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vb/early-readiness-version-fix

Comment @coderabbitai help to get the list of available commands.

@vladbologa
vladbologa requested a review from mclasmeier August 14, 2026 07:01
@vladbologa vladbologa changed the title Fix early-readiness version check for ACS 4.9 (#269) Fix early-readiness version check for ACS 4.9 Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #269 by tightening the version gate used when --early-readiness=false, preventing roxie from waiting on an Available condition that does not exist on older StackRox/ACS operator-managed CRs (notably in mixed-version deployments).

Changes:

  • Update the minimum supported operator version for the relevant readiness/feature gate from >= 4.9.0 to >= 4.10.0.
  • Align the inline documentation with the updated constraint value.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/stackroxversions/constraints.go
Comment thread internal/stackroxversions/constraints.go
@vladbologa
vladbologa merged commit 612cb27 into main Aug 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants