refactor(widget): share skeleton layouts and prevent layout flash - #568
Open
petar-omni wants to merge 1 commit into
Open
petar-omni wants to merge 1 commit into
petar-omni wants to merge 1 commit into
Conversation
|
petar-omni
added this pull request to stack #569
September 15, 2026 21:49
petar-omni
force-pushed
the
refactor/shared-skeleton-layouts
branch
2 times, most recently
from
September 16, 2026 11:46
14fc46e to
c1e413c
Compare
Consolidate loading placeholders across widget flows and keep initial price layouts stable. Replace loading-time zero values and delayed native-token detection. This prevents visual shifts and button flashes during initial rendering. - Align select trigger skeletons with loaded geometry and add CaretDownIcon loading support. - Prevent select provider card unmount flash while multi-yield queries resolve. - Add strategy details skeleton placeholder above divider under dashboard variant. - Preserve dual-column layout balance for estimated reward amounts during loading. - Add loading accessibility and disabled states to MaxButton. - Align amount-token-section min/max label alignment with flexbox container.
petar-omni
force-pushed
the
refactor/shared-skeleton-layouts
branch
from
September 17, 2026 06:04
c1e413c to
2ed3477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Prevent visible layout shifts and transient controls during initial rendering, while keeping loading UI consistent across widget flows.
Dependency
Stacked on #567; merge the Vitest/Effect upgrade first.