Drop upload quorum from IpfsMultiUploadClient - #208
Merged
Merged
Conversation
tsudmi
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #207 every upload client verifies the provider-returned CID against the uploaded content and returns it in canonical form, or raises. All successful responses in
IpfsMultiUploadClient._uploadare therefore always identical, and the majority quorum check can never fail: it only counted successful responses, so a single verified upload already satisfied it.get_quorumand the hash counting inIpfsMultiUploadClient._upload; return the first verified hash, or raise when every client failed.ipfs_unixfsmodule docstring.