Repository navigation
Conversation
staktrace
enabled auto-merge (rebase)
October 5, 2026 01:35
staktrace
disabled auto-merge
October 5, 2026 01:37
Contributor
Clippy has "incomptible_msrv" check, but testing MSRV explicitly by installing old Rust and running the tests is still worth it IMO, clippy may not catch everything. I guess removed "msrv" job was broken and did not actually use installed old Rust. |
Owner
Author
Yeah, exactly. Otherwise that job would have failed CI when the edition was bumped to 2024 and other code changes were made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146. In doing so I discovered that when the edition was bumped to 2024, the MSRV was also implicitly at least 1.85.0. Rather than rolling back to MSRV 1.51.0, I decided to just roll forward with this new MSRV. This also adds clippy in CI to enforce compatibility going forward.