Unify explicit filter initialization across inference methods - #276
Merged
Merged
Conversation
SamDuffield
added this pull request to stack #278
September 9, 2026 14:41
Sahel13
approved these changes
Sep 14, 2026
Sahel13
left a comment
Sahel13
left a comment
Collaborator
There was a problem hiding this comment.
Fixed some breaking tests, and cleaned up some allocations while I was at it.
Sahel13
removed this pull request from stack #278
September 15, 2026 08:05
Sahel13
added a commit
that referenced
this pull request
Sep 15, 2026
* replace init_state's model_inputs before concat * simplify init_prepare for kalman * Unify explicit filter initialization across inference methods (#276) * Unify explicit filter initialization across inference methods * Remove unused model inputs from factorial initialization hook * Manual pass, cleaning up cuthbert * Remove new test * fix tests, remove extra allocs --------- Co-authored-by: Sahel Iqbal <sahel13miqbal@proton.me> --------- Co-authored-by: SamDuffield <34280297+SamDuffield@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the initialization refactor to discrete, moments/Taylor Gaussian, particle, marginal particle, and ensemble Kalman filters. Prior parameters are supplied to
build_filter, initial samplers take only a random key, andinit_prepare()no longer acceptsmodel_inputs.Update step preparation, factorial filtering and history conversion to handle priors with
model_inputs=None. Remove obsolete initialization callback protocols and migrate tests, documentation, and examples to the unified API.Validation:
git diff --checkpassed.