Repository navigation
Fix nested internal refs - #3
Merged
Merged
Conversation
When inlining nested interal references, the inliner loses the full context of the schema and crashes (since it is trying to resolve a reference that does not exist in the sub schema it is currently working with). Keep track of the full schema for the file that is being process and pass that down to be able to resolve absolute internal references.
Original schema comes from checkit, remove all the additional fluff that has nothing to do with the issue.
sunkan
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed an issue when trying to inline a (probably old) schema from checkit. The inliner seems to lose context and not be able to solve absolute references. Inlining resulted in an
JsonPointer\Exceptions\InvalidPointer: Invalid pointer syntax.Fix this by keeping track of the file that is being processed so that absolute references can be resolved that way.
Added a couple of examples that highlight the issue.