You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This page still tells readers to clone and follow soroban-examples v23.0.0, but that tag depends on soroban-sdk 23.0.1 and its implementation calls deploy_v2. The new v28-only call therefore neither matches the cited source nor compiles in the documented checkout. Please coordinate/pin a v28 example source (including its ContractExecutable import) before switching this snippet.
The setup links and clones soroban-examples main, but current main pins soroban-sdk 27.0.0 and the referenced deployer still calls deploy_v2. This v28-only snippet does not match or compile with the project readers are instructed to use. Update the example source to v28 and pin the guide to that revision before changing the call.
This guide cites the v23.0.0 upgradeable contract, whose Cargo file pins soroban-sdk 23.0.1 and whose source uses update_current_contract_wasm. Replacing only the displayed call makes the guide diverge from its runnable source and documented setup. Please first provide and pin a v28 example revision, then update the snippet and source links together.
The page instructs readers to clone soroban-examples main, but that token currently pins soroban-token-sdk 27.0.0 and constructs Approve with expiration_ledger: live_until_ledger. Field shorthand for live_until_ledger is valid in v28 but fails in the documented checkout, so this no longer reproduces the linked example. Coordinate/pin the token example's v28 dependency update before changing this line.
> [!NOTE]
> Part of a series of related and connected PRs:
>
> - #18 ← this PR
> - stellar/soroban-examples#420
> - stellar/stellar-docs#2863
### What
Bump the workspace to soroban-sdk v28.
### Why
Keep it updated.
### Known Limitations
The `stellar contract build` is because the soroban-sdk has to be built
with the cli now, unfortunately even for libs that aren't intended to be
cdylibs. The reason is that the soroban-sdk can't detect when building a
lib vs targeting a .wasm file and it errors to prevent people
accidentally building contracts with `cargo build`.
The linked event reference is still stale: docs/learn/fundamentals/stellar-data-structures/events.mdx:141 says this event is emitted only by update_current_contract_wasm. In v28, update_current_contract_executable_ref emits the same event as well, so readers following this link receive incomplete behavior documentation. Please update that page to cover both executable update paths.
The v28 dependency update is incomplete: docs/learn/migrate/evm/solidity-and-rust-basics.mdx:576-579 is another current EVM migration example and still instructs readers to use soroban-sdk 27. Please bump both of those declarations to 28 so the docs consistently satisfy this PR's stated v28 update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Part of a series of related and connected PRs:
What
Update existing examples and docs to match the soroban-examples and soroban-sdk v28.
Why
Keep the docs updated.
Dependent on:
Known Limitations
This change does not introduce new docs about new features.