Protocol 30 (CAP-0087) - #318
Merged
Merged
Conversation
Nine new ContractCostType entries (86-94) covering verifying-key decode, signature decode, and verification for ML-DSA-44/65/87, gated behind CAP_0087_ML_DSA.
This was referenced Sep 14, 2026
jayz22
approved these changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The guarded enum additions match CAP-0087 and preserve the existing feature-off definition.
Pull request overview
Adds CAP-0087 ML-DSA metering definitions while preserving feature-off compatibility.
Changes:
- Adds nine ML-DSA cost types numbered 86–94.
- Gates additions behind
CAP_0087_ML_DSA.
File summaries
| File | Description |
|---|---|
Stellar-contract-config-setting.x |
Extends ContractCostType with guarded ML-DSA costs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ContractCostTypeentries (86–94) for ML-DSA-44/65/87 verifying-key decode, signature decode, and signature verification, gated behind#ifdef CAP_0087_ML_DSA.CAP_0084_MUXED_CONTRACTarm inSCAddressType.Downstream: rs-stellar-xdr, then rs-soroban-env / go-stellar-sdk / js-stellar-base / js-stellar-sdk / js-stellar-xdr-json pin this PR's head SHA.