Skip to content

Fix global search array-to-string crashes - #62

Merged
CrazyBoy49z merged 10 commits into
mainfrom
fix/search-array-values
Sep 25, 2026
Merged

CrazyBoy49z merged 10 commits into
mainfrom
fix/search-array-values

Conversation

@CrazyBoy49z

Copy link
Copy Markdown
Member

Fixes the Array to string conversion seen on /admin/search in host apps with translation groups such as lang/uk/page.php and lang/uk/user.php.

Root cause:

  • search providers used bare __('Page'), __('User'), and __('Setting') labels;
  • on case-insensitive filesystems these can resolve to translation group arrays;
  • SearchRegistry then blindly cast provider values to strings.

Changes:

  • use package-namespaced search translations for all search labels and result types;
  • normalize custom provider values safely, including localized arrays;
  • skip malformed search results instead of casting arrays;
  • keep user search working when the host app does not expose a user.show route;
  • use primary keys for user detail URLs;
  • add regression tests for localized array provider values and malformed results.

@CrazyBoy49z
CrazyBoy49z merged commit 179a40a into main Sep 25, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant