Fix global user search regression test isolation - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing CI job after #64.
The production change is fine. The new regression test was executing the entire app-level SearchRegistry while the test admin still had the moderator role, so the pages provider ran first. In Testbench there is no translatable locales config/pages setup for that unrelated provider, which caused
LocalesNotDefinedExceptionbefore the users provider assertion was reached.This change isolates the test to the
users.viewpermission only, so the global search registry executes the users provider being tested without invoking unrelated page/settings providers.