Skip to content

Moved from DFT settings to DFT environments - #469

Merged
volkm merged 3 commits into
stormchecker:masterfrom
volkm:dft-adaption
Sep 28, 2026
Merged

volkm merged 3 commits into
stormchecker:masterfrom
volkm:dft-adaption

Conversation

@volkm

@volkm volkm commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Adaption to changes in storm-dft introduced in stormchecker/storm#1037.
Most notably, moved from settings to environments.

Minor: added convenience helper make check.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Update Storm dependency compatibility, declare check phony, and add environment-binding coverage.

Review effort: Lite
Findings: 2 High severity · 1 Medium severity

Open (3)
What changed in this PR

Migrates DFT bindings from settings to DftEnvironment objects and adds a unified check command.

Changes:

  • Adds Python bindings for DFT environments.
  • Updates DFT analysis and model-builder APIs.
  • Updates tests and adds make check.
File Summary
tests/​dft/​test_analysis.py Updates DFT builder tests.
src/​mod_dft.cpp Registers environment bindings.
src/​dft/​environment.h Declares environment binding setup.
src/​dft/​environment.cpp Adds environment bindings; compatibility and coverage issues remain.
src/​dft/​dft.cpp Removes obsolete settings initialization.
src/​dft/​analysis.cpp Passes environments into DFT analysis; Storm dependency compatibility must be updated.
Makefile Adds check; it must also be declared phony.
lib/​stormpy/​dft/​__init__.py Updates Python DFT wrappers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/dft/analysis.cpp
Comment thread src/dft/environment.cpp
Comment thread Makefile
@volkm
volkm merged commit 9d7df4c into stormchecker:master Sep 28, 2026
23 checks passed
@volkm
volkm deleted the dft-adaption branch September 28, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants