Moved from DFT settings to DFT environments - #469
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update Storm dependency compatibility, declare check phony, and add environment-binding coverage.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Migrates DFT bindings from settings to DftEnvironment objects and adds a unified check command.
Changes:
- Adds Python bindings for DFT environments.
- Updates DFT analysis and model-builder APIs.
- Updates tests and adds
make check.
| File | Summary |
|---|---|
tests/dft/test_analysis.py |
Updates DFT builder tests. |
src/mod_dft.cpp |
Registers environment bindings. |
src/dft/environment.h |
Declares environment binding setup. |
src/dft/environment.cpp |
Adds environment bindings; compatibility and coverage issues remain. |
src/dft/dft.cpp |
Removes obsolete settings initialization. |
src/dft/analysis.cpp |
Passes environments into DFT analysis; Storm dependency compatibility must be updated. |
Makefile |
Adds check; it must also be declared phony. |
lib/stormpy/dft/__init__.py |
Updates Python DFT wrappers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adaption to changes in
storm-dftintroduced in stormchecker/storm#1037.Most notably, moved from settings to environments.
Minor: added convenience helper
make check.